gh-152433: Windows: allow posixmodule.c to build for Windows UWP#152998
gh-152433: Windows: allow posixmodule.c to build for Windows UWP#152998thexai wants to merge 1 commit into
posixmodule.c to build for Windows UWP#152998Conversation
1a0e742 to
a9bed96
Compare
|
Please don't force push to CPython PR Branches. The issue description here is a little confusing as this shows up as the module :mod:`!nt`:(The For the windows specific pieces need review from @python/windows-team |
|
The change looks fine to me, and in line with my comments on the other PR we merged earlier today, let's just skip NEWS here (all that changes is that a failing custom build becomes a successful one). |
|
NEWS removed. |
|
I'm sure you'll be told again, but every time you force push a small change, we cannot verify your change. You force us to re-review the entire pull request again, because the incremental change you made is gone. That annoys us and slows us down. You'll get fewer reviews and find it harder to get your changes merged. Please just work with us here. We always squash merge, so intermediate commits won't show up anyway, and we usually rewrite commit messages to make sure the important information is included. The commit history within a PR is there to serve the reviewers, and force pushing is the best way to not serve the reviewers. |
|
I understand, but I only removed NEWS and assumed it was the easiest way. |
Windows: allow
posixmodule.cto build for Windows UWP.